Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the project compatible with Python 3. #1

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Making the project compatible with Python 3. #1

merged 2 commits into from
Jan 6, 2021

Conversation

Squirrel18
Copy link

@Squirrel18 Squirrel18 commented Dec 29, 2020 •
edited
Loading

Description:

This PR:

  • Adds support for Python 3. Cherry-picked from: https://github.com/edx/edx-analytics-exporter/pull/48
  • Fixes an error when replacing SQL results.
  • Pins some requirements to avoid errors due to Python 3.5 end of life.
  • Allows passing empty usernames to the mongoexport command.
  • Adds --authenticationDatabase param to the Mongo export command.

Reviewers:

@Squirrel18 Squirrel18 changed the title WIP - Making the project compatible with Python 3.5 WIP - Making the project compatible with Python 3. Dec 30, 2020
@Squirrel18 Squirrel18 marked this pull request as ready for review December 31, 2020 05:14
@Squirrel18 Squirrel18 changed the title WIP - Making the project compatible with Python 3. Making the project compatible with Python 3. Dec 31, 2020
diegomillan
diegomillan approved these changes Dec 31, 2020
View reviewed changes
Copy link

@diegomillan diegomillan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I don't have any other suggestions, and it looks good to me @Squirrel18

@Squirrel18
Add authenticationDatabase param to the mongoexport command.
3282f8f 
Making the requirements Python 3.5 compatible.
Allow passing empty username to the mongoexport command.
Avoid failing on non-string values.
@Squirrel18 Squirrel18 merged commit e91f6d4 into master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomillan diegomillan diegomillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Squirrel18 @diegomillan @mraarif